Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.h

Issue 2161963002: Add some initial histograms about subresource filtering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sbsf_dsf
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/subresource_filter_agent.h
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.h b/components/subresource_filter/content/renderer/subresource_filter_agent.h
index b89cd88cab0bce8208d07e56f7854d94c74d3693..cd31c7bab6dc1bf07a57a1272123a335df2d614a 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent.h
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "components/subresource_filter/core/common/activation_state.h"
#include "content/public/renderer/render_frame_observer.h"
@@ -51,17 +52,22 @@ class SubresourceFilterAgent : public content::RenderFrameObserver {
private:
void ActivateForProvisionalLoad(ActivationState activation_state);
+ void RecordHistogramsOnLoadCommitted();
+ void RecordHistogramsOnLoadFinished();
+
// content::RenderFrameObserver:
void OnDestruct() override;
void DidStartProvisionalLoad() override;
void DidCommitProvisionalLoad(bool is_new_navigation,
bool is_same_page_navigation) override;
+ void DidFinishLoad() override;
bool OnMessageReceived(const IPC::Message& message) override;
// Owned by the ChromeContentRendererClient and outlives us.
RulesetDealer* ruleset_dealer_;
ActivationState activation_state_for_provisional_load_;
+ base::WeakPtr<DocumentSubresourceFilter> filter_for_last_committed_load_;
DISALLOW_COPY_AND_ASSIGN(SubresourceFilterAgent);
};

Powered by Google App Engine
This is Rietveld 408576698