Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2161923002: Move WorkerThreadLifecycleObserver::contextDestroyed out of SafePointScope (Closed)

Created:
4 years, 5 months ago by yhirano
Modified:
4 years, 5 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WorkerThreadLifecycleObserver::contextDestroyed out of SafePointScope Oilpan forbids to allocate objects in a SafePointScope. It is too restrictive for WorkerThreadLifecycleObserver::contextDestroyed, so this CL moves the WorkerThreadLifecycleContext::notifyContextDestroyed call out of SafePointScope. BUG=587663 Committed: https://crrev.com/e60df82a17421fbdc64e1798ba65ad27370e5d5f Cr-Commit-Position: refs/heads/master@{#406275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -62 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +70 lines, -62 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
yhirano
4 years, 5 months ago (2016-07-19 03:38:59 UTC) #4
nhiroki
lgtm
4 years, 5 months ago (2016-07-19 07:40:11 UTC) #7
yhirano
+kinuko@ for OWNER review.
4 years, 5 months ago (2016-07-19 07:43:30 UTC) #9
kinuko
lgtm
4 years, 5 months ago (2016-07-19 12:53:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161923002/1
4 years, 5 months ago (2016-07-19 14:06:43 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 15:03:44 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 15:03:46 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:06:00 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e60df82a17421fbdc64e1798ba65ad27370e5d5f
Cr-Commit-Position: refs/heads/master@{#406275}

Powered by Google App Engine
This is Rietveld 408576698