[blink][android] Fix --adb-device in the layout test runner.

[blink][android] Fix --adb-device in the layout test runner.

BUG=567947
Committed: https://crrev.com/a55b358f33f382b0ecb08320626bce54c99a467d
Cr-Commit-Position: refs/heads/master@{#406297}

[jbudorick, 2016-07-19 00:33:11]

jbudorick@chromium.org changed reviewers:
+ dpranke@chromium.org, qyearsley@chromium.org

[Dirk Pranke, 2016-07-19 00:46:15]

lgtm

[jbudorick, 2016-07-19 00:47:00]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:48:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 02:03:44]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbudorick, 2016-07-19 14:28:00]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2016-07-19 14:28:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2161913002/#ps40001
(title: "fix AndroidPortTest.test_default_child_processes")

[commit-bot: I haz the power, 2016-07-19 14:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:06:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 17:07:53]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 17:09:55]

Description was changed from

==========
[blink][android] Fix --adb-device in the layout test runner.

BUG=567947
==========

to

==========
[blink][android] Fix --adb-device in the layout test runner.

BUG=567947

Committed: https://crrev.com/a55b358f33f382b0ecb08320626bce54c99a467d
Cr-Commit-Position: refs/heads/master@{#406297}
==========

[commit-bot: I haz the power, 2016-07-19 17:09:56]

Patchset 3 (id:??) landed as
https://crrev.com/a55b358f33f382b0ecb08320626bce54c99a467d
Cr-Commit-Position: refs/heads/master@{#406297}

[qyearsley, 2016-07-19 17:14:50]

On 2016/07/19 at 17:07:53, commit-bot wrote:
> CQ bit was unchecked.

So, specifically, this patch makes it so that default_devices (in the
AndroidDevices class) is a list rather than a single device.

It looks like previously, the value of the adb_device option once parsed was
already a list -- so it was broken before, because a list was obtained from
options, but a single device ID was expected for the AndroidDevices class -- is
that right?

[jbudorick, 2016-07-19 17:18:52]

On 2016/07/19 17:14:50, qyearsley wrote:
> On 2016/07/19 at 17:07:53, commit-bot wrote:
> > CQ bit was unchecked.
> 
> So, specifically, this patch makes it so that default_devices (in the
> AndroidDevices class) is a list rather than a single device.
> 
> It looks like previously, the value of the adb_device option once parsed was
> already a list -- so it was broken before, because a list was obtained from
> options, but a single device ID was expected for the AndroidDevices class --
is
> that right?

Yep.

[qyearsley, 2016-07-19 17:23:41]

On 2016/07/19 at 17:18:52, jbudorick wrote:
> On 2016/07/19 17:14:50, qyearsley wrote:
> > On 2016/07/19 at 17:07:53, commit-bot wrote:
> > > CQ bit was unchecked.
> > 
> > So, specifically, this patch makes it so that default_devices (in the
> > AndroidDevices class) is a list rather than a single device.
> > 
> > It looks like previously, the value of the adb_device option once parsed was
> > already a list -- so it was broken before, because a list was obtained from
> > options, but a single device ID was expected for the AndroidDevices class --
is
> > that right?
> 
> Yep.

Excellent, thanks