third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py - Issue 2161913002: [blink][android] Fix --adb-device in the layout test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

Issue 2161913002: [blink][android] Fix --adb-device in the layout test runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix AndroidPortTest.test_default_child_processes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

index 8878ade7d62c55987c1aa840786095dee8646ab4..6fca14b8f4af30aefe953f2911d703113cc29223 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

@@ -186,7 +186,7 @@ class AndroidPortTest(port_testcase.PortTestCase):

# Test that the number of child processes to create depends on the devices.

def test_default_child_processes(self):

port_default = self.make_port(device_count=5)

- port_fixed_device = self.make_port(device_count=5, options=optparse.Values({'adb_device': '123456789ABCDEF9'}))

+ port_fixed_device = self.make_port(device_count=5, options=optparse.Values({'adb_devices': ['123456789ABCDEF9']}))

self.assertEquals(5, port_default.default_child_processes())

self.assertEquals(1, port_fixed_device.default_child_processes())