Fix MultiPictureDraw issues with GpuImageDecodeController

Fix MultiPictureDraw issues with GpuImageDecodeController

Currently, the GpuImageDecodeController (GPU IDC) is used during the
initial playback of a RasterSource. Unfortunately, the initial playback
is just used to generate an SkPicture, not to actually raster. Actual
rasterization happens later, via MultiPictureDraw. Because of this the
calls to GetDecodedImageForDraw and DrawWithImageFinished on the GPU IDC
do not scope Skia's usage of an image, as was intended. This can lead
to lifetime issues, especially with large, software-backed images.

This change moves the usage of ImageHijackCanvas and the GPU IDC to the
later MultiPictureDraw phase, allowing lifetimes to line up as expected.

TBR=vmpstr@chromium.org
BUG=612329, 628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149843003
Cr-Commit-Position: refs/heads/master@{#405649}
(cherry picked from commit 1259d6e73e7f8904243aa3451bc9071a18f93cbd)

Committed: https://chromium.googlesource.com/chromium/src/+/0701df60264a6aa83032e19f49c6040ee4c4042d

[ericrk, 2016-07-18 20:48:55]

Description was changed from

==========
Fix MultiPictureDraw issues with GpuImageDecodeController

Currently, the GpuImageDecodeController (GPU IDC) is used during the
initial playback of a RasterSource. Unfortunately, the initial playback
is just used to generate an SkPicture, not to actually raster. Actual
rasterization happens later, via MultiPictureDraw. Because of this the
calls to GetDecodedImageForDraw and DrawWithImageFinished on the GPU IDC
do not scope Skia's usage of an image, as was intended. This can lead
to lifetime issues, especially with large, software-backed images.

This change moves the usage of ImageHijackCanvas and the GPU IDC to the
later MultiPictureDraw phase, allowing lifetimes to line up as expected.

R=vmpstr@chromium.org
BUG=612329,628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149843003
Cr-Commit-Position: refs/heads/master@{#405649}
(cherry picked from commit 1259d6e73e7f8904243aa3451bc9071a18f93cbd)
==========

to

==========
Fix MultiPictureDraw issues with GpuImageDecodeController

Currently, the GpuImageDecodeController (GPU IDC) is used during the
initial playback of a RasterSource. Unfortunately, the initial playback
is just used to generate an SkPicture, not to actually raster. Actual
rasterization happens later, via MultiPictureDraw. Because of this the
calls to GetDecodedImageForDraw and DrawWithImageFinished on the GPU IDC
do not scope Skia's usage of an image, as was intended. This can lead
to lifetime issues, especially with large, software-backed images.

This change moves the usage of ImageHijackCanvas and the GPU IDC to the
later MultiPictureDraw phase, allowing lifetimes to line up as expected.

TBR=vmpstr@chromium.org
BUG=612329,628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149843003
Cr-Commit-Position: refs/heads/master@{#405649}
(cherry picked from commit 1259d6e73e7f8904243aa3451bc9071a18f93cbd)
==========

[ericrk, 2016-07-18 20:49:53]

Patchset #2 (id:20001) has been deleted

[ericrk, 2016-07-18 20:50:33]

Patchset #1 (id:1) has been deleted

[ericrk, 2016-07-18 21:45:05]

Description was changed from

==========
Fix MultiPictureDraw issues with GpuImageDecodeController

Currently, the GpuImageDecodeController (GPU IDC) is used during the
initial playback of a RasterSource. Unfortunately, the initial playback
is just used to generate an SkPicture, not to actually raster. Actual
rasterization happens later, via MultiPictureDraw. Because of this the
calls to GetDecodedImageForDraw and DrawWithImageFinished on the GPU IDC
do not scope Skia's usage of an image, as was intended. This can lead
to lifetime issues, especially with large, software-backed images.

This change moves the usage of ImageHijackCanvas and the GPU IDC to the
later MultiPictureDraw phase, allowing lifetimes to line up as expected.

TBR=vmpstr@chromium.org
BUG=612329,628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149843003
Cr-Commit-Position: refs/heads/master@{#405649}
(cherry picked from commit 1259d6e73e7f8904243aa3451bc9071a18f93cbd)
==========

to

==========
Fix MultiPictureDraw issues with GpuImageDecodeController

Currently, the GpuImageDecodeController (GPU IDC) is used during the
initial playback of a RasterSource. Unfortunately, the initial playback
is just used to generate an SkPicture, not to actually raster. Actual
rasterization happens later, via MultiPictureDraw. Because of this the
calls to GetDecodedImageForDraw and DrawWithImageFinished on the GPU IDC
do not scope Skia's usage of an image, as was intended. This can lead
to lifetime issues, especially with large, software-backed images.

This change moves the usage of ImageHijackCanvas and the GPU IDC to the
later MultiPictureDraw phase, allowing lifetimes to line up as expected.

TBR=vmpstr@chromium.org
BUG=612329,628394
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2149843003
Cr-Commit-Position: refs/heads/master@{#405649}
(cherry picked from commit 1259d6e73e7f8904243aa3451bc9071a18f93cbd)

Committed:
https://chromium.googlesource.com/chromium/src/+/0701df60264a6aa83032e19f49c6...
==========

[ericrk, 2016-07-18 21:45:06]

Committed patchset #2 (id:60001) manually as
0701df60264a6aa83032e19f49c6040ee4c4042d (presubmit successful).