Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2161593003: Fix rewinding bug in SkJpegCodec (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix rewinding bug in SkJpegCodec Performing a sampled and/or subset decode will create some state in SkJpegCodec. If we fail to clean up this state properly, subsequent decodes may try to reuse (and potentailly overflow) the leftover memory. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161593003 Committed: https://skia.googlesource.com/skia/+/4ecb8ab556214c9337f56bc36d50e4d7c655ac7a Committed: https://skia.googlesource.com/skia/+/2812f03d54b7fa4fd3d724505155d44a5343d91b

Patch Set 1 #

Patch Set 2 : GOOGLE 3 fix - doesn't affect Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M src/codec/SkJpegCodec.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
M tests/CodecTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
msarett
4 years, 5 months ago (2016-07-18 17:10:41 UTC) #3
djsollen
lgtm
4 years, 5 months ago (2016-07-18 17:13:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161593003/1
4 years, 5 months ago (2016-07-18 17:13:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4ecb8ab556214c9337f56bc36d50e4d7c655ac7a
4 years, 5 months ago (2016-07-18 17:28:44 UTC) #8
msarett
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2155163004/ by msarett@google.com. ...
4 years, 5 months ago (2016-07-18 22:19:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161593003/20001
4 years, 5 months ago (2016-07-18 22:21:34 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:56:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2812f03d54b7fa4fd3d724505155d44a5343d91b

Powered by Google App Engine
This is Rietveld 408576698