third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html - Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html

Issue 2161583004: Tracing: re-use JSONTraceDataSink in DevTools' tracing handler... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html

index 6c11d723b8c9b60630935790a52a79d4b81ebf12..fe517d5ef7b36b2a9ba5bab24bc2d522be2f567c 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html

@@ -62,7 +62,9 @@ function test()

function onCloseAfterClose(response)

{

InspectorTest.log("Error after illegal close: " + JSON.stringify(response.error));

- performEventsSanityCheck(JSON.parse(data1));

+ var trace = JSON.parse(data1)

dgozman 2016/07/19 01:53:14 nit: missing semicolon

+ performEventsSanityCheck(trace["traceEvents"]);

+ assertEqual("object", typeof trace["metadata"]);

dgozman 2016/07/19 01:53:14 Let's dump the typeof instead?

}

« content/browser/devtools/protocol/tracing_handler.cc ('K') | « content/browser/tracing/tracing_controller_impl_data_sinks.cc ('k') | no next file » | no next file with comments »