Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2161583002: Make BrowsingDataRemover mockable and filter builders comparable (Closed)

Created:
4 years, 5 months ago by msramek
Modified:
4 years, 5 months ago
Reviewers:
Mike West
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make BrowsingDataRemover mockable and filter builders comparable This was extracted from https://codereview.chromium.org/2025683003/ where it will be needed for ChromeContentBrowserClient tests. BUG=607897 Committed: https://crrev.com/23a715e8dc89937b85f320d8e86645919c6164ab Cr-Commit-Position: refs/heads/master@{#405979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.h View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/origin_filter_builder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/origin_filter_builder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/registrable_domain_filter_builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/registrable_domain_filter_builder.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
Mike West
lgtm LGTM, given the tests in the next patch.
4 years, 5 months ago (2016-07-18 10:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161583002/1
4 years, 5 months ago (2016-07-18 10:08:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/245539)
4 years, 5 months ago (2016-07-18 11:55:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161583002/1
4 years, 5 months ago (2016-07-18 11:56:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 12:22:55 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 12:22:58 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 12:24:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23a715e8dc89937b85f320d8e86645919c6164ab
Cr-Commit-Position: refs/heads/master@{#405979}

Powered by Google App Engine
This is Rietveld 408576698