chrome/browser/browsing_data/origin_filter_builder.cc - Issue 2161583002: Make BrowsingDataRemover mockable and filter builders comparable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/origin_filter_builder.cc

Issue 2161583002: Make BrowsingDataRemover mockable and filter builders comparable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/origin_filter_builder.h ('k') | chrome/browser/browsing_data/registrable_domain_filter_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/origin_filter_builder.cc

diff --git a/chrome/browser/browsing_data/origin_filter_builder.cc b/chrome/browser/browsing_data/origin_filter_builder.cc

index 2562569c6ba738c7eb6afc8482f9082f632634e7..4d13835cf4a539ccb033eeec428154bc37f185f6 100644

--- a/chrome/browser/browsing_data/origin_filter_builder.cc

+++ b/chrome/browser/browsing_data/origin_filter_builder.cc

@@ -84,6 +84,10 @@ OriginFilterBuilder::BuildChannelIDFilter() const {

return base::Bind(DontDeleteAnythingFilter<std::string>);

}

+bool OriginFilterBuilder::operator==(const OriginFilterBuilder& other) const {

+ return origin_list_ == other.origin_list_ && mode() == other.mode();

bool OriginFilterBuilder::IsEmpty() const {

return origin_list_.empty();

}