Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2161423003: CacheStorage: caches.match with bad cacheName should resolve with undefined. (Closed)

Created:
4 years, 5 months ago by zino
Modified:
4 years, 5 months ago
Reviewers:
jkarlin, jsbell, nhiroki
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: caches.match with bad cacheName should resolve with undefined. Make caches.match(request, options)'s promise resolve with undefined (rather than reject) when options.cacheName is given but no corresponding Cache object is found. Related spec issue: https://github.com/slightlyoff/ServiceWorker/issues/891 BUG=610349 Committed: https://crrev.com/9916998beca540fc96101352626d49fd0193dca8 Cr-Commit-Position: refs/heads/master@{#406817}

Patch Set 1 #

Total comments: 2

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js View 1 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorageError.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
zino
PTAL
4 years, 5 months ago (2016-07-20 14:40:05 UTC) #3
nhiroki
I'm somewhat concerned that this change may break some real applications. jsbell@ and jkarlin@, any ...
4 years, 5 months ago (2016-07-20 16:05:45 UTC) #5
jsbell
On 2016/07/20 16:05:45, nhiroki (slow) wrote: > I'm somewhat concerned that this change may break ...
4 years, 5 months ago (2016-07-20 17:40:48 UTC) #6
zino
nhiroki@, I addressed test. PTAL. https://codereview.chromium.org/2161423003/diff/1/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js File third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js (right): https://codereview.chromium.org/2161423003/diff/1/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js#newcode115 third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js:115: 'with undefined.'); On 2016/07/20 ...
4 years, 5 months ago (2016-07-21 08:10:15 UTC) #7
nhiroki
On 2016/07/20 17:40:48, jsbell wrote: > On 2016/07/20 16:05:45, nhiroki (slow) wrote: > > I'm ...
4 years, 5 months ago (2016-07-21 08:56:24 UTC) #8
nhiroki
LGTM
4 years, 5 months ago (2016-07-21 08:56:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161423003/20001
4 years, 5 months ago (2016-07-21 09:50:03 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 10:58:13 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 10:59:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9916998beca540fc96101352626d49fd0193dca8
Cr-Commit-Position: refs/heads/master@{#406817}

Powered by Google App Engine
This is Rietveld 408576698