third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp - Issue 2161423003: CacheStorage: caches.match with bad cacheName should resolve with undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

Issue 2161423003: CacheStorage: caches.match with bad cacheName should resolve with undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js ('k') | third_party/WebKit/Source/modules/cachestorage/CacheStorageError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

index 2abd491b89c71d0103046243b240ce6989cf2a77..ec8460cdf35ef6adfb7aca6dfbaa9593b0e5cf41 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

@@ -140,7 +140,7 @@ public:

{

if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

- if (reason == WebServiceWorkerCacheErrorNotFound)

+ if (reason == WebServiceWorkerCacheErrorNotFound || reason == WebServiceWorkerCacheErrorCacheNameNotFound)

m_resolver->resolve();

else

m_resolver->reject(CacheStorageError::createException(reason));