Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2161363005: Convert some component source sets to static library (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some component source sets to static library This is hoping to achieve better build performance. BUG=627637 Committed: https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4 Cr-Commit-Position: refs/heads/master@{#406975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M components/dom_distiller/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/error_page/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/content/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/favicon_base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/gcm_driver/crypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/image_fetcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/language_usage_metrics/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_coordinator/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_coordinator/child/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/memory_pressure/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics_services_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
brettw
4 years, 5 months ago (2016-07-21 21:44:07 UTC) #4
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 22:07:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161363005/1
4 years, 5 months ago (2016-07-21 22:26:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:45:11 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:48:07 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4
Cr-Commit-Position: refs/heads/master@{#406975}

Powered by Google App Engine
This is Rietveld 408576698