components/favicon_base/BUILD.gn - Issue 2161363005: Convert some component source sets to static library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon_base/BUILD.gn

Issue 2161363005: Convert some component source sets to static library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("favicon_base") {	5 static_library("favicon_base") {

6 sources = [	6 sources = [

7 "fallback_icon_style.cc",	7 "fallback_icon_style.cc",

8 "fallback_icon_style.h",	8 "fallback_icon_style.h",

9 "fallback_icon_url_parser.cc",	9 "fallback_icon_url_parser.cc",

10 "fallback_icon_url_parser.h",	10 "fallback_icon_url_parser.h",

11 "favicon_callback.h",	11 "favicon_callback.h",

12 "favicon_types.cc",	12 "favicon_types.cc",

13 "favicon_types.h",	13 "favicon_types.h",

14 "favicon_url_parser.cc",	14 "favicon_url_parser.cc",

15 "favicon_url_parser.h",	15 "favicon_url_parser.h",

(...skipping 30 matching lines...) Expand all Loading...
46	46

47 deps = [	47 deps = [

48 ":favicon_base",	48 ":favicon_base",

49 "//testing/gtest",	49 "//testing/gtest",

50 "//ui/base",	50 "//ui/base",

51 "//ui/gfx",	51 "//ui/gfx",

52 "//ui/gfx/geometry",	52 "//ui/gfx/geometry",

53 "//url",	53 "//url",

54 ]	54 ]

55 }	55 }

OLD	NEW

« no previous file with comments | « components/favicon/core/BUILD.gn ('k') | components/feedback/BUILD.gn » ('j') | no next file with comments »