Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2161283002: Fix Dart 1.17 strong-mode warnings. (Closed)

Created:
4 years, 5 months ago by nweiz
Modified:
4 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/delegate/future.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/delegate/stream_subscription.dart View 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/typed/future.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/typed/stream.dart View 3 chunks +10 lines, -8 lines 0 comments Download
M lib/src/typed/stream_subscription.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/restartable_timer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/result_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M test/stream_completer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/stream_queue_test.dart View 13 chunks +14 lines, -14 lines 0 comments Download
M test/stream_splitter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/stream_zip_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/subscription_stream_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/typed_wrapper/future_test.dart View 5 chunks +4 lines, -14 lines 0 comments Download
M test/typed_wrapper/stream_subscription_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/typed_wrapper/stream_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M test/utils.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 5 months ago (2016-07-19 21:45:58 UTC) #1
kevmoo
lgtm
4 years, 5 months ago (2016-07-19 21:51:26 UTC) #2
nweiz
4 years, 5 months ago (2016-07-19 21:52:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3656b103d98c4aca0d01fc35d409892c8c1c8247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698