third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html - Issue 2161253002: DevTools: Use proper target when processing worker thread events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html

index cdea0cc45fc134df8276cdea0db15d7fa387189a..b0e22aa78d1e2df79f6be0a10b4a8a5a30edb727 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html

@@ -38,10 +38,10 @@ function test()

if (!recordTypes.has(event.name))

return;

- var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, InspectorTest.timelineModel().target());

+ var detailsText = WebInspector.TimelineUIUtils.buildDetailsTextForTraceEvent(event, InspectorTest.timelineModel().targetByEvent(event));

InspectorTest.addResult("detailsTextContent for " + event.name + " event: '" + detailsText + "'");

- var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, InspectorTest.timelineModel().target(), linkifier);

+ var details = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, InspectorTest.timelineModel().targetByEvent(event), linkifier);

if (!details)

return;

InspectorTest.addResult("details.textContent for " + event.name + " event: '" + details.textContent.replace(/VM[\d]+/, "VM") + "'");