Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2161253002: DevTools: Use proper target when processing worker thread events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index d567d30be2f1cdd11ed018ecab218be3c76bfecc..269bb7ed6f52698ef5e72568c6cca14a8052e50e 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -774,7 +774,7 @@ WebInspector.TimelinePanel.prototype = {
this._statusPane.updateStatus(WebInspector.UIString("Processing timeline\u2026"));
this._model.setEvents(this._tracingModel, loadedFromFile);
this._frameModel.reset();
- this._frameModel.addTraceEvents(this._model.target(), this._model.inspectedTargetEvents(), this._model.sessionId() || "");
+ this._frameModel.addTraceEvents(WebInspector.targetManager.mainTarget(), this._model.inspectedTargetEvents(), this._model.sessionId() || "");
var groups = WebInspector.TimelineModel.AsyncEventGroup;
var asyncEventsByGroup = this._model.mainThreadAsyncEvents();
@@ -1088,7 +1088,7 @@ WebInspector.TimelinePanel.prototype = {
*/
_showEventInPaintProfiler: function(event, isCloseable)
{
- var target = this._model.target();
+ var target = this._model.targetByEvent(event);
caseq 2016/07/19 22:48:58 I think it should be fine to use main target here,
alph 2016/07/19 23:10:29 Done.
if (!target)
return;
var paintProfilerView = this._paintProfilerView();

Powered by Google App Engine
This is Rietveld 408576698