pre-land special methods on device

pre-land special methods on device

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002

Committed: https://skia.googlesource.com/skia/+/e51c356ae4e074b9c286c50a4efce11205f7463c

[reed1, 2016-07-19 20:16:02]

Description was changed from

==========
pre-land special methods on device

BUG=skia:
==========

to

==========
pre-land special methods on device

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002
==========

[reed1, 2016-07-19 20:16:09]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-07-19 20:16:10]

ptal

[reed1, 2016-07-19 20:16:15]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 20:16:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:38:18]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-19 21:08:05]

lgtm

https://codereview.chromium.org/2161233002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/2161233002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:2236: const SkIRect clipBounds =
draw.fRC->getBounds().makeOffset(-x, -y);
Should be override getImageFilterCache for the SkPDFDevice so it does what the
GPUDevice does (i.e., create a transient one)?

[reed1, 2016-07-19 21:32:13]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-07-19 21:32:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-19 21:32:26]

https://codereview.chromium.org/2161233002/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/2161233002/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:2236: const SkIRect clipBounds =
draw.fRC->getBounds().makeOffset(-x, -y);
On 2016/07/19 21:08:04, robertphillips wrote:
> Should be override getImageFilterCache for the SkPDFDevice so it does what the
> GPUDevice does (i.e., create a transient one)?

Good catch. I think its just a public/protected issue. It can get access to the
same cache we use on the bitmapdevice side.

[reed1, 2016-07-19 21:32:34]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-07-19 21:32:37]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-07-19 21:32:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 21:33:22]

Description was changed from

==========
pre-land special methods on device

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002
==========

to

==========
pre-land special methods on device

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161233002

Committed:
https://skia.googlesource.com/skia/+/e51c356ae4e074b9c286c50a4efce11205f7463c
==========

[commit-bot: I haz the power, 2016-07-19 21:33:23]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e51c356ae4e074b9c286c50a4efce11205f7463c