include/core/SkDevice.h - Issue 2161233002: pre-land special methods on device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkDevice.h

Issue 2161233002: pre-land special methods on device (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkDevice.h

diff --git a/include/core/SkDevice.h b/include/core/SkDevice.h

index 864f71225f79125bbad57ca6f32635f6549818db..827897c20e45209d63246c8b153e71ab7094a1a3 100644

--- a/include/core/SkDevice.h

+++ b/include/core/SkDevice.h

@@ -279,7 +279,7 @@ protected:

virtual void drawSpecial(const SkDraw&, SkSpecialImage*, int x, int y, const SkPaint&);

virtual sk_sp<SkSpecialImage> makeSpecial(const SkBitmap&);

- virtual sk_sp<SkSpecialImage> makeSpecial(SkImage*);

+ virtual sk_sp<SkSpecialImage> makeSpecial(const SkImage*);

virtual sk_sp<SkSpecialImage> snapSpecial();

bool readPixels(const SkImageInfo&, void* dst, size_t rowBytes, int x, int y);