Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2161223002: Update rounding/clamping comments on sk_linear_to_srgb(). (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update rounding/clamping comments on sk_linear_to_srgb(). Rounding is enough. No need for an explicit clamp if the inputs are in range. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2161223002 Committed: https://skia.googlesource.com/skia/+/d1bd2082c59826b5f54cdbc7354f91fe033ece41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/core/SkSRGB.h View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/SRGBTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-19 20:15:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161223002/1
4 years, 5 months ago (2016-07-19 20:15:55 UTC) #5
msarett
lgtm
4 years, 5 months ago (2016-07-19 20:16:54 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 20:36:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d1bd2082c59826b5f54cdbc7354f91fe033ece41

Powered by Google App Engine
This is Rietveld 408576698