Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: tests/SRGBTest.cpp

Issue 2161223002: Update rounding/clamping comments on sk_linear_to_srgb(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkSRGB.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkSRGB.h" 8 #include "SkSRGB.h"
9 #include "SkTypes.h" 9 #include "SkTypes.h"
10 #include "Test.h" 10 #include "Test.h"
11 #include <math.h> 11 #include <math.h>
12 12
13 static uint8_t linear_to_srgb(float l) { 13 static uint8_t linear_to_srgb(float l) {
14 return (uint8_t)roundf(sk_linear_to_srgb(Sk4f{l})[0]); 14 // Round float to int, truncate that to uint8_t.
15 return (uint8_t)Sk4f_round( sk_linear_to_srgb(Sk4f{l}) )[0];
15 } 16 }
16 17
17 DEF_TEST(sk_linear_to_srgb, r) { 18 DEF_TEST(sk_linear_to_srgb, r) {
18 // Should map 0 -> 0 and 1 -> 1. 19 // Should map 0 -> 0 and 1 -> 1.
19 REPORTER_ASSERT(r, 0 == linear_to_srgb(0.0f)); 20 REPORTER_ASSERT(r, 0 == linear_to_srgb(0.0f));
20 REPORTER_ASSERT(r, 255 == linear_to_srgb(1.0f)); 21 REPORTER_ASSERT(r, 255 == linear_to_srgb(1.0f));
21 22
22 // Should be monotonic between 0 and 1. 23 // Should be monotonic between 0 and 1.
23 // We don't bother checking denorm values. 24 // We don't bother checking denorm values.
24 int tolerated_regressions = 0; 25 int tolerated_regressions = 0;
25 #if defined(SK_ARM_HAS_NEON) 26 #if defined(SK_ARM_HAS_NEON)
26 // Values around 0.166016 are usually 72 but drop briefly (41 floats) down t o 71. 27 // Values around 0.166016 are usually 72 but drop briefly (41 floats) down t o 71.
27 tolerated_regressions = 1; 28 tolerated_regressions = 1;
28 #endif 29 #endif
29 uint8_t prev = 0; 30 uint8_t prev = 0;
30 for (float f = FLT_MIN; f <= 1.0f; ) { 31 for (float f = FLT_MIN; f <= 1.0f; ) {
31 uint8_t srgb = linear_to_srgb(f); 32 uint8_t srgb = linear_to_srgb(f);
32 33
33 REPORTER_ASSERT(r, srgb >= prev || tolerated_regressions > 0); 34 REPORTER_ASSERT(r, srgb >= prev || tolerated_regressions > 0);
34 if (srgb < prev) { tolerated_regressions--; } 35 if (srgb < prev) { tolerated_regressions--; }
35 prev = srgb; 36 prev = srgb;
36 37
37 union { float flt; uint32_t bits; } pun = { f }; 38 union { float flt; uint32_t bits; } pun = { f };
38 pun.bits++; 39 pun.bits++;
39 f = pun.flt; 40 f = pun.flt;
40 } 41 }
41 } 42 }
OLDNEW
« no previous file with comments | « src/core/SkSRGB.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698