Add tools/mac/show_mod_init_func.py to symbolize static initializers without a dSYM.

Add tools/mac/show_mod_init_func.py to symbolize static initializers without a dSYM.

BUG=628052
R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/03a19d56c6b11996704a6871d52d05bc6f252328

[Mark Mentovai, 2016-07-19 17:31:15]

LGTM

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
File tools/mac/show_mod_init_func.py (right):

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
tools/mac/show_mod_init_func.py:44: if len(lines) == 1:
I don’t think you need this. lines[2:] will be [] in the next branch, so the
return will also just be [].

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
tools/mac/show_mod_init_func.py:60: atos = ['atos', '-o', binary] + addresses
If there are a lot of addresses, you could run out of space for argv. Hopefully
there aren’t anywhere near that many, though. But an alternative is to feed atos
on its stdin, which would actually allow you to get rid of the “if not
initializers” special case in ShowModuleInitializers().

[Robert Sesek, 2016-07-19 18:02:22]

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
File tools/mac/show_mod_init_func.py (right):

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
tools/mac/show_mod_init_func.py:44: if len(lines) == 1:
On 2016/07/19 17:31:15, Mark Mentovai wrote:
> I don’t think you need this. lines[2:] will be [] in the next branch, so the
> return will also just be [].

You're right. I always forget that [2:] doesn't count as an IndexError.

https://codereview.chromium.org/2161093002/diff/1/tools/mac/show_mod_init_fun...
tools/mac/show_mod_init_func.py:60: atos = ['atos', '-o', binary] + addresses
On 2016/07/19 17:31:15, Mark Mentovai wrote:
> If there are a lot of addresses, you could run out of space for argv.
Hopefully
> there aren’t anywhere near that many, though. But an alternative is to feed
atos
> on its stdin, which would actually allow you to get rid of the “if not
> initializers” special case in ShowModuleInitializers().

There are only ever a few static initializers so I think it's fine to pass them
on argv.

[commit-bot: I haz the power, 2016-07-19 18:29:50]

Description was changed from

==========
Add tools/mac/show_mod_init_func.py to symbolize static initializers without a
dSYM.

BUG=628052
R=mark@chromium.org
==========

to

==========
Add tools/mac/show_mod_init_func.py to symbolize static initializers without a
dSYM.

BUG=628052
R=mark@chromium.org

Committed: https://crrev.com/03a19d56c6b11996704a6871d52d05bc6f252328
Cr-Commit-Position: refs/heads/master@{#406325}
==========

[commit-bot: I haz the power, 2016-07-19 18:29:51]

Patchset 2 (id:??) landed as
https://crrev.com/03a19d56c6b11996704a6871d52d05bc6f252328
Cr-Commit-Position: refs/heads/master@{#406325}

[Robert Sesek, 2016-07-19 18:30:47]

Description was changed from

==========
Add tools/mac/show_mod_init_func.py to symbolize static initializers without a
dSYM.

BUG=628052
R=mark@chromium.org

Committed: https://crrev.com/03a19d56c6b11996704a6871d52d05bc6f252328
Cr-Commit-Position: refs/heads/master@{#406325}
==========

to

==========
Add tools/mac/show_mod_init_func.py to symbolize static initializers without a
dSYM.

BUG=628052
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/03a19d56c6b11996704a6871d52d...
==========

[Robert Sesek, 2016-07-19 18:30:48]

Committed patchset #2 (id:20001) manually as
03a19d56c6b11996704a6871d52d05bc6f252328 (presubmit successful).