🎫 Fail write_build_config.py if current_toolchain != default_toolchain

build/config/android/internal_rules.gni

Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 6da9a33c1e3240d84a90087582464c893fca7fa7..3625a62a9047c83b19e48eb30754072a298b6380 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -333,6 +333,14 @@ template("write_build_config") {
           rebase_path(invoker.bundled_srcjars, root_build_dir)
       args += [ "--bundled-srcjars=$_rebased_bundled_srcjars" ]
     }
+    if (current_toolchain != default_toolchain) {
+      _msg = [

[brettw, 2016/07/26 20:29:48]

Can you add a comment here about why we fail with a build message rather than
assert. If I saw this code I would "fix" it.

[agrieve, 2016/07/27 02:27:13]

Good point. Future me would be tempted to do the same.

+        "Tried to build an Android target in a non-default toolchain.",
+        "target: " + get_label_info(":$target_name", "label_with_toolchain"),
+        "default_toolchain: $default_toolchain",
+      ]
+      args += [ "--fail=$_msg" ]
+    }
   }
 }