🎫 Fail write_build_config.py if current_toolchain != default_toolchain

build/config/android/internal_rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
 assert(is_android)
 
 # These identify targets that have .build_config files (except for android_apk,
@@ skipping 315 matching lines @@
       args += [
         "--srcjar",
         rebase_path(invoker.srcjar, root_build_dir),
       ]
     }
     if (defined(invoker.bundled_srcjars)) {
       _rebased_bundled_srcjars =
           rebase_path(invoker.bundled_srcjars, root_build_dir)
       args += [ "--bundled-srcjars=$_rebased_bundled_srcjars" ]
     }
+    if (current_toolchain != default_toolchain) {
+      _msg = [

[brettw, 2016/07/26 20:29:48]

Can you add a comment here about why we fail with a build message rather than
assert. If I saw this code I would "fix" it.

[agrieve, 2016/07/27 02:27:13]

Good point. Future me would be tempted to do the same.

+        "Tried to build an Android target in a non-default toolchain.",
+        "target: " + get_label_info(":$target_name", "label_with_toolchain"),
+        "default_toolchain: $default_toolchain",
+      ]
+      args += [ "--fail=$_msg" ]
+    }
   }
 }
 
 template("copy_ex") {
   set_sources_assignment_filter([])
   action(target_name) {
     forward_variables_from(invoker,
                            [
                              "data",
                              "deps",
@@ skipping 2212 matching lines @@
       outputs = [
         depfile,
         invoker.out_manifest,
       ]
       inputs = [
         invoker.main_manifest,
       ]
     }
   }
 }