Changing the default path for RemoteSecurityKeyIpcServer test channels

remoting/host/security_key/security_key_ipc_constants.cc

Index: remoting/host/security_key/security_key_ipc_constants.cc
diff --git a/remoting/host/security_key/security_key_ipc_constants.cc b/remoting/host/security_key/security_key_ipc_constants.cc
index e9aeb8685750951c6d5d1ea5598e9240d23c27da..d335174092d5a5c0971f6ea8787e63aa033d3cbb 100644
--- a/remoting/host/security_key/security_key_ipc_constants.cc
+++ b/remoting/host/security_key/security_key_ipc_constants.cc
@@ -33,10 +33,10 @@ void SetSecurityKeyIpcChannelNameForTest(const std::string& channel_name) {
 
 std::string GetChannelNamePathPrefixForTest() {
   std::string path_prefix;
-#if defined(OS_LINUX)
-  path_prefix = "/dev/socket/";
+#if defined(OS_POSIX)
+  path_prefix = "/tmp/";
   std::unique_ptr<base::Environment> env(base::Environment::Create());
-  if (env->GetVar(base::env_vars::kHome, &path_prefix))
+  if (env->GetVar(base::env_vars::kTempDir, &path_prefix))

[Lei Zhang, 2016/07/19 22:07:30]

Can you just call base::GetTempDir() instead?

If your tests has trouble cleaning up after itself for whatever reason, have you
tried using a base::ScopedTempDir, and putting everything in there? That way,
when the ScopedTempDir gets destroyed, everything inside goes away. (Not 100%
sure about Windows if there are still open files in the ScopedTempDir.)

[Sergey Ulanov, 2016/07/19 22:34:57]

Looks like we have base::GetTempDir() in base/files/file_util.h . Use it here
instead accessing env directly?

[joedow, 2016/07/19 23:04:12]

Done.

[joedow, 2016/07/19 23:04:12]

Done.

     path_prefix += "/";
 #endif
   return path_prefix;