Changing the default path for RemoteSecurityKeyIpcServer test channels

remoting/host/security_key/security_key_ipc_constants.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/security_key/security_key_ipc_constants.h"
 
 #include "base/environment.h"
 #include "base/lazy_instance.h"
 
 namespace {
 base::LazyInstance<std::string> g_security_key_ipc_channel_name =
     LAZY_INSTANCE_INITIALIZER;
 
 const char kSecurityKeyIpcChannelName[] = "security_key_ipc_channel";
 
 }  // namespace
 
 namespace remoting {
 
 extern const char kSecurityKeyConnectionError[] = "ssh_connection_error";

[Lei Zhang, 2016/07/19 22:07:30]

Drive by: "extern" should not be used in .cc files.

[joedow, 2016/07/19 23:04:12]

Done.

 
 const std::string& GetSecurityKeyIpcChannelName() {
   if (g_security_key_ipc_channel_name.Get().empty()) {
     g_security_key_ipc_channel_name.Get() = kSecurityKeyIpcChannelName;
   }
 
   return g_security_key_ipc_channel_name.Get();
 }
 
 void SetSecurityKeyIpcChannelNameForTest(const std::string& channel_name) {
   g_security_key_ipc_channel_name.Get() = channel_name;
 }
 
 std::string GetChannelNamePathPrefixForTest() {
   std::string path_prefix;
-#if defined(OS_LINUX)
-  path_prefix = "/dev/socket/";
+#if defined(OS_POSIX)
+  path_prefix = "/tmp/";
   std::unique_ptr<base::Environment> env(base::Environment::Create());
-  if (env->GetVar(base::env_vars::kHome, &path_prefix))
+  if (env->GetVar(base::env_vars::kTempDir, &path_prefix))

[Lei Zhang, 2016/07/19 22:07:30]

Can you just call base::GetTempDir() instead?

If your tests has trouble cleaning up after itself for whatever reason, have you
tried using a base::ScopedTempDir, and putting everything in there? That way,
when the ScopedTempDir gets destroyed, everything inside goes away. (Not 100%
sure about Windows if there are still open files in the ScopedTempDir.)

[Sergey Ulanov, 2016/07/19 22:34:57]

Looks like we have base::GetTempDir() in base/files/file_util.h . Use it here
instead accessing env directly?

[joedow, 2016/07/19 23:04:12]

Done.

[joedow, 2016/07/19 23:04:12]

Done.

     path_prefix += "/";
 #endif
   return path_prefix;
 }
 
 }  // namespace remoting