Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp

Issue 2161003002: CustomElements: upgrade element patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@upgrade-element
Patch Set: RegistryTest update, removed setting element`s state to custom in the test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
index d4b7049f5f97616aa08e615c2d5760ff12e0cad8..1a810a9c7ef0febf748a04a2af890c4de3d93a15 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp
@@ -61,7 +61,9 @@ void V8HTMLElement::constructorCustom(
element = HTMLElement::create(
QualifiedName(nullAtom, definition->descriptor().localName(), HTMLNames::xhtmlNamespaceURI),
*window->document());
+ // TODO(davaajav): write this as one call to setCustomElementState instead of two
element->setCustomElementState(CustomElementState::Undefined);
+ element->setCustomElementState(CustomElementState::Custom);
} else {
element = definition->constructionStack().last();
if (element) {
@@ -91,10 +93,6 @@ void V8HTMLElement::constructorCustom(
v8CallOrCrash(wrapper->SetPrototype(
scriptState->context(),
definition->prototype()));
-
- // TODO(dominicc): Move this to the exactly correct place when
- // https://github.com/whatwg/html/issues/1297 is closed.
- element->setCustomElementState(CustomElementState::Custom);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698