Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp

Issue 2161003002: CustomElements: upgrade element patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@upgrade-element
Patch Set: RegistryTest update, removed setting element`s state to custom in the test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
index 32dc346ea99baab57c6066e6f681d9a44a86826b..49a31397f4aafb2e8cecb022af5a766142d7620b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
@@ -9,11 +9,13 @@
#include "bindings/core/v8/V8BindingMacros.h"
#include "bindings/core/v8/V8CustomElementsRegistry.h"
#include "bindings/core/v8/V8Element.h"
+#include "bindings/core/v8/V8ErrorHandler.h"
#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/V8ScriptRunner.h"
#include "bindings/core/v8/V8ThrowException.h"
#include "core/dom/ExceptionCode.h"
#include "core/dom/custom/CustomElement.h"
+#include "core/events/ErrorEvent.h"
#include "core/html/HTMLElement.h"
#include "v8.h"
#include "wtf/Allocator.h"
@@ -224,18 +226,23 @@ bool ScriptCustomElementDefinition::runConstructor(Element* element)
tryCatch.SetVerbose(true);
Element* result = runConstructor();
- if (!result)
+
+ // To report exception thrown from runConstructor()
+ if (tryCatch.HasCaught())
return false;
+ // To report InvalidStateError Exception, when the constructor returns some differnt object
if (result != element) {
- V8ThrowException::throwException(
- V8ThrowException::createDOMException(
- m_scriptState->isolate(),
- InvalidStateError,
- "custom element constructors must call super() first and must "
- "not return a different object",
- constructor()),
- m_scriptState->isolate());
+ const String& message = "custom element constructors must call super() first and must "
+ "not return a different object";
+
+ std::unique_ptr<SourceLocation> location = SourceLocation::fromFunction(constructor().As<v8::Function>());
+ v8::Local<v8::Value> exception = V8ThrowException::createDOMException(
+ m_scriptState->isolate(),
+ InvalidStateError,
+ message,
+ constructor());
+ fireErrorEvent(m_scriptState.get(), message, exception, std::move(location));
return false;
}
@@ -260,6 +267,14 @@ Element* ScriptCustomElementDefinition::runConstructor()
return V8Element::toImplWithTypeCheck(isolate, result);
}
+void ScriptCustomElementDefinition::fireErrorEvent(ScriptState* scriptState, const String& message, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation> location)
+{
+ ErrorEvent* event = ErrorEvent::create(message, std::move(location), &scriptState->world());
+ V8ErrorHandler::storeExceptionOnErrorEventWrapper(scriptState, event, exception, scriptState->context()->Global());
+ ExecutionContext* executionContext = scriptState->getExecutionContext();
+ executionContext->reportException(event, NotSharableCrossOrigin);
+}
+
v8::Local<v8::Object> ScriptCustomElementDefinition::constructor() const
{
DCHECK(!m_constructor.isEmpty());

Powered by Google App Engine
This is Rietveld 408576698