telemetry/telemetry/internal/platform/profiler/trace_profiler.py - Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/profiler/trace_profiler.py

Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py ('k') | telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/profiler/trace_profiler.py

diff --git a/telemetry/telemetry/internal/platform/profiler/trace_profiler.py b/telemetry/telemetry/internal/platform/profiler/trace_profiler.py

index 76b5632f5af0becc2ad589e47913ea6e2db4c9a6..4a7c48ff8e53e778390f9859830ccc85ad1141a4 100644

--- a/telemetry/telemetry/internal/platform/profiler/trace_profiler.py

+++ b/telemetry/telemetry/internal/platform/profiler/trace_profiler.py

@@ -42,7 +42,8 @@ class TraceProfiler(profiler.Profiler):

print 'Processing trace...'

trace_result_builder = trace_data_module.TraceDataBuilder()

- self._browser_backend.StopTracing(trace_result_builder)

+ self._browser_backend.StopTracing()

+ self._browser_backend.CollectTracingData(trace_result_builder)

trace_result = trace_result_builder.AsData()

trace_file = '%s.zip' % self._output_path