Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

Issue 2160953003: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: [Telemetry][Tracing] Split StopTracing and CollectTraceData for Chrome Tracing Agent. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
index 6181bffd696c147dad4ec0125f0fa1c167d27242..865a3f396d135ec58928b498129503f93080b87f 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py
@@ -188,6 +188,23 @@ class TracingBackendUnitTest(unittest.TestCase):
'Tracing is already started',
backend.StartTracing, config.chrome_trace_config)
+ def testStartTracingWithoutCollection(self):
+ self._inspector_socket.AddResponseHandler('Tracing.start', lambda req: {})
+ self._inspector_socket.AddEvent(
+ 'Tracing.dataCollected', {'value': [{'ph': 'B'}]}, 1)
+ self._inspector_socket.AddEvent(
+ 'Tracing.dataCollected', {'value': [{'ph': 'E'}]}, 2)
+ self._inspector_socket.AddEvent('Tracing.tracingComplete', {}, 3)
+ self._inspector_socket.AddResponseHandler(
+ 'Tracing.hasCompleted', lambda req: {})
+
+ backend = tracing_backend.TracingBackend(self._inspector_socket)
+ config = tracing_config.TracingConfig()
+ backend.StartTracing(config._chrome_trace_config)
+ backend.StopTracing()
+ with self.assertRaisesRegexp(AssertionError, 'Data not collected from .*'):
+ backend.StartTracing(config._chrome_trace_config)
+
class DevToolsStreamPerformanceTest(unittest.TestCase):
def setUp(self):

Powered by Google App Engine
This is Rietveld 408576698