Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2160863003: Disable qcms on build for Android framework (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable qcms on build for Android framework BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2160863003 Committed: https://skia.googlesource.com/skia/+/ff1740394e23ba23c8e78e3c06f7940103fa3c8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M gyp/common_conditions.gypi View 2 chunks +6 lines, -3 lines 0 comments Download
M gyp/ports.gyp View 2 chunks +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
msarett
I think this should build just fine on the Android framework.
4 years, 5 months ago (2016-07-19 15:35:23 UTC) #4
djsollen
lgtm
4 years, 5 months ago (2016-07-19 17:54:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160863003/20001
4 years, 5 months ago (2016-07-19 17:55:04 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:17:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/ff1740394e23ba23c8e78e3c06f7940103fa3c8b

Powered by Google App Engine
This is Rietveld 408576698