[iOS/GN] Fix generation of .dSYM for fat binary builds.

[iOS/GN] Fix generation of .dSYM for fat binary builds.

When creating fat binaries, the generation of the .dSYM file need to
use the fat binary and not the intermediate binaries. So for a fat
build, //build/config/mac:strip_all is an empty configuration and the
linker tools do not pass the flag requesting generation of the .dSYM
file to linker_driver.py, instead the flags are passed when "lipo" is
invoked.

Fix //build/toolchain/mac/linker_driver.py to look for both "-o" and
"-output" when looking for the linker output to allow wrapping "lipo"
in addition to the compiler linker (as "lipo" only accept "-output"
flag to specify the output file).

Always add //build/config/mac:strip_all to the dependencies of all
linkable targets on iOS (as is done on Mac) and fix cronet.

BUG=593582
Committed: https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d
Cr-Commit-Position: refs/heads/master@{#406253}

[sdefresne, 2016-07-18 15:38:29]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 15:39:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-18 15:41:19]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org, rsesek@chromium.org

[sdefresne, 2016-07-18 15:41:19]

Robert: please take a look as initial implementer of the .dSYM generation. I've
tested this locally, and I correctly get .dSYM generated for Chromium.app with
the correct content when setting enable_dsyms=true.

out/gn-Debug-iphoneos/Chromium.dSYM/Contents/Resources/DWARF/Chromium:          
    Mach-O universal binary with 2 architectures
out/gn-Debug-iphoneos/Chromium.dSYM/Contents/Resources/DWARF/Chromium (for
architecture armv7):	Mach-O dSYM companion file arm
out/gn-Debug-iphoneos/Chromium.dSYM/Contents/Resources/DWARF/Chromium (for
architecture arm64):	Mach-O 64-bit dSYM companion file

Brett: can you review as OWNERS?

[commit-bot: I haz the power, 2016-07-18 17:03:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 17:03:30]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-07-18 17:53:38]

lgtm

[Robert Sesek, 2016-07-18 20:09:43]

Nifty, glad this was easy to hook up.

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/BUILD.gn
File build/config/mac/BUILD.gn (right):

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/BUILD.gn#n...
build/config/mac/BUILD.gn:107: if (enable_stripping && (!is_ios ||
additional_toolchains == [])) {
Considering making |!is_ios || additional_toolchains == []| a variable, given
that it's a bit unwieldy to reason about.

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/base_rules...
File build/config/mac/base_rules.gni (right):

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/base_rules...
build/config/mac/base_rules.gni:348: args += [ "-Wcrl,strip,-x,-S" ]
Does nothing on iOS need to control the strip args to a framework?

https://codereview.chromium.org/2160653002/diff/1/build/toolchain/mac/linker_...
File build/toolchain/mac/linker_driver.py (right):

https://codereview.chromium.org/2160653002/diff/1/build/toolchain/mac/linker_...
build/toolchain/mac/linker_driver.py:167: except ValueError as _:
Don't need an |as _| here if you're just catching by type.

[sdefresne, 2016-07-19 09:10:38]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 09:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-19 09:12:13]

Robert, thank you for the quick review.

Could you take another look?

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/BUILD.gn
File build/config/mac/BUILD.gn (right):

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/BUILD.gn#n...
build/config/mac/BUILD.gn:107: if (enable_stripping && (!is_ios ||
additional_toolchains == [])) {
On 2016/07/18 20:09:42, Robert Sesek wrote:
> Considering making |!is_ios || additional_toolchains == []| a variable, given
> that it's a bit unwieldy to reason about.

Done.

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/base_rules...
File build/config/mac/base_rules.gni (right):

https://codereview.chromium.org/2160653002/diff/1/build/config/mac/base_rules...
build/config/mac/base_rules.gni:348: args += [ "-Wcrl,strip,-x,-S" ]
On 2016/07/18 20:09:43, Robert Sesek wrote:
> Does nothing on iOS need to control the strip args to a framework?

I've changed to check whether //build/config/mac:strip_all is in configs.

https://codereview.chromium.org/2160653002/diff/1/build/toolchain/mac/linker_...
File build/toolchain/mac/linker_driver.py (right):

https://codereview.chromium.org/2160653002/diff/1/build/toolchain/mac/linker_...
build/toolchain/mac/linker_driver.py:167: except ValueError as _:
On 2016/07/18 20:09:43, Robert Sesek wrote:
> Don't need an |as _| here if you're just catching by type.

Done.

[sdefresne, 2016-07-19 09:18:10]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-07-19 09:18:25]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-07-19 09:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 09:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:23:26]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[sdefresne, 2016-07-19 10:11:49]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 10:12:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:17:03]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-07-19 12:09:03]

LGTM

[sdefresne, 2016-07-19 12:38:01]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-19 12:38:01]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2160653002/#ps60001
(title: "Rebase and add support for save_unstripped_output.")

[commit-bot: I haz the power, 2016-07-19 12:38:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 12:42:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-19 12:43:58]

Description was changed from

==========
[iOS/GN] Fix generation of .dSYM for fat binary builds.

When creating fat binaries, the generation of the .dSYM file need to
use the fat binary and not the intermediate binaries. So for a fat
build, //build/config/mac:strip_all is an empty configuration and the
linker tools do not pass the flag requesting generation of the .dSYM
file to linker_driver.py, instead the flags are passed when "lipo" is
invoked.

Fix //build/toolchain/mac/linker_driver.py to look for both "-o" and
"-output" when looking for the linker output to allow wrapping "lipo"
in addition to the compiler linker (as "lipo" only accept "-output"
flag to specify the output file).

Always add //build/config/mac:strip_all to the dependencies of all
linkable targets on iOS (as is done on Mac) and fix cronet.

BUG=593582
==========

to

==========
[iOS/GN] Fix generation of .dSYM for fat binary builds.

When creating fat binaries, the generation of the .dSYM file need to
use the fat binary and not the intermediate binaries. So for a fat
build, //build/config/mac:strip_all is an empty configuration and the
linker tools do not pass the flag requesting generation of the .dSYM
file to linker_driver.py, instead the flags are passed when "lipo" is
invoked.

Fix //build/toolchain/mac/linker_driver.py to look for both "-o" and
"-output" when looking for the linker output to allow wrapping "lipo"
in addition to the compiler linker (as "lipo" only accept "-output"
flag to specify the output file).

Always add //build/config/mac:strip_all to the dependencies of all
linkable targets on iOS (as is done on Mac) and fix cronet.

BUG=593582

Committed: https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d
Cr-Commit-Position: refs/heads/master@{#406253}
==========

[commit-bot: I haz the power, 2016-07-19 12:43:59]

Patchset 3 (id:??) landed as
https://crrev.com/6e714433f6749c3664ca816d1c64a488828ef75d
Cr-Commit-Position: refs/heads/master@{#406253}