[iOS/GN] Fix generation of .dSYM for fat binary builds.

build/config/mac/base_rules.gni

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file contains rules that are shared between Mac and iOS.
 
 import("//build/toolchain/toolchain.gni")
+import("//build/config/mac/symbols.gni")
 
 if (is_mac) {
   import("//build/config/mac/mac_sdk.gni")
 } else if (is_ios) {
   import("//build/config/ios/ios_sdk.gni")
 }
 
 # Convert plist file to given format.
 #
 # Arguments
@@ skipping 289 matching lines @@
       output_name = _output_name
       output_prefix_override = true
       output_extension = ""
       output_dir = "$target_out_dir/$_link_shared_library_target"
     }
 
     if (_is_fat_build) {
       action(_lipo_shared_library_target) {
         forward_variables_from(invoker, [ "testonly" ])
         visibility = _lipo_shared_library_visibility
-        script = "//build/config/mac/xcrun.py"
+        script = "//build/toolchain/mac/linker_driver.py"
         outputs = [
           "$target_out_dir/$_lipo_shared_library_target/$_output_name",
         ]
         inputs = [
           "$target_out_dir/$_link_shared_library_target/$_output_name",
         ]
         deps = [
           ":$_link_shared_library_target",
         ]
         foreach(_additional_toolchain, additional_toolchains) {
           _additional_toolchain_target = "$_target_name($_additional_toolchain)"
           deps += [ ":$_additional_toolchain_target" ]
           inputs += [ get_label_info(_additional_toolchain_target,
                                      "target_out_dir") + "/$_output_name" ]
         }
         args = [
+                 "xcrun",
                  "lipo",
                  "-create",
                  "-output",
                  rebase_path(outputs[0], root_build_dir),
                ] + rebase_path(inputs, root_build_dir)
+
+        if (enable_dsyms) {
+          outputs += [ "$root_out_dir/$_output_name.dSYM/" ]
+          args +=
+              [ "-Wcrl,dsym," + rebase_path("$root_out_dir/.", root_build_dir) ]
+        }
+        if (enable_stripping) {
+          args += [ "-Wcrl,strip,-x,-S" ]

[Robert Sesek, 2016/07/18 20:09:43]

Does nothing on iOS need to control the strip args to a framework?

[sdefresne, 2016/07/19 09:12:12]

I've changed to check whether //build/config/mac:strip_all is in configs. 

+        }
       }
     }
 
     bundle_data(_shared_library_bundle_data) {
       visibility = [ ":$_framework_target" ]
       forward_variables_from(invoker, [ "testonly" ])
       outputs = [
         "{{bundle_executable_dir}}/$_output_name",
       ]
       if (_is_fat_build) {
@@ skipping 119 matching lines @@
     ]
     args =
         [
           "--input",
           "{{source}}",
           "--output",
           rebase_path("$target_gen_dir/$target_name/{{source_name_part}}.nib"),
         ] + ibtool_flags
   }
 }