Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2160573003: S390: Fix convertion from int32 to float32 (Closed)

Created:
4 years, 5 months ago by john.yan
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix convertion from int32 to float32 Should use the same Mask code as float32 to int32 R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/94e1c858e3f24cd46d7374120eed1acce8cf2207 Cr-Commit-Position: refs/heads/master@{#37871}

Patch Set 1 #

Patch Set 2 : more fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/s390/assembler-s390.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
john.yan
PTAL
4 years, 5 months ago (2016-07-18 19:24:37 UTC) #1
JaideepBajwa
lgtm
4 years, 5 months ago (2016-07-18 19:26:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160573003/20001
4 years, 5 months ago (2016-07-19 13:42:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 14:07:08 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 14:07:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/94e1c858e3f24cd46d7374120eed1acce8cf2207
Cr-Commit-Position: refs/heads/master@{#37871}

Powered by Google App Engine
This is Rietveld 408576698