Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2160563004: Cherry-pick fix for GrAADistanceFieldPathRenderer bounds to M53 (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@m53
Target Ref:
refs/heads/chrome/m53
Project:
skia
Visibility:
Public.

Description

Cherry-pick fix for GrAADistanceFieldPathRenderer bounds to M53. ----------- Initialize fGammaCorrect in DF Path Renderer unit test TBR=jvanverth@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157933003 Review-Url: https://codereview.chromium.org/2157933003 Fix leak when DFPR fails to draw path TBR=jvanverth@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144283002 Review-Url: https://codereview.chromium.org/2144283002 Make GrBatchAtlas robust against attempts to add large rects. Make GrAADistanceFieldPathRenderer robust against paths that in src space wind up being too large for the atlas. BUG=chromium:627443 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144663004 Review-Url: https://codereview.chromium.org/2144663004 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/042215e3d5336a52245945eb790ce41fa79138b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -28 lines) Patch
M src/gpu/GrBatchAtlas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 5 chunks +20 lines, -23 lines 0 comments Download
A tests/DFPathRendererTest.cpp View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160563004/1
4 years, 5 months ago (2016-07-18 21:28:48 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:28:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/042215e3d5336a52245945eb790ce41fa79138b7

Powered by Google App Engine
This is Rietveld 408576698