Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2144663004: Make GrBatchAtlas robust against attempts to add large rects. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrBatchAtlas robust against attempts to add large rects. Make GrAADistanceFieldPathRenderer robust against paths that in src space wind up being too large for the atlas. BUG=chromium:627443 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2144663004 Committed: https://skia.googlesource.com/skia/+/6d6b6ad0f30504b6d0540f1f6bc7c072f33e85b2

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup add test #

Patch Set 4 : cleanup, comment #

Patch Set 5 : Fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -28 lines) Patch
M src/gpu/GrBatchAtlas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 2 5 chunks +19 lines, -23 lines 0 comments Download
A tests/DFPathRendererTest.cpp View 1 2 3 4 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
bsalomon
4 years, 5 months ago (2016-07-13 20:54:21 UTC) #3
jvanverth1
lgtm
4 years, 5 months ago (2016-07-13 21:08:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144663004/60001
4 years, 5 months ago (2016-07-13 21:13:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/9658)
4 years, 5 months ago (2016-07-13 21:16:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144663004/80001
4 years, 5 months ago (2016-07-13 21:21:01 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 21:45:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6d6b6ad0f30504b6d0540f1f6bc7c072f33e85b2

Powered by Google App Engine
This is Rietveld 408576698