Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 2160503002: Use Document::validBaseElementURL to init preloadscanner (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Use Document::validBaseElementURL to init preloadscanner Before this CL, Document::baseElementURL was used to initialize PreloadScanner. However, this URL can be !isValid(). This CL introduces Document::validBaseElementURL() which returns baseElementURL only when its valid, end returns empty URL when its invalid. This can safely be used to initialize preload scanner. BUG=623365 Review-Url: https://codereview.chromium.org/2132283002 Cr-Commit-Position: refs/heads/master@{#404595} (cherry picked from commit 51b5da563d004465a203dd40892a13b8543721e1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/parser/preloader-base-invalidurl.html View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/parser/preloader-base-invalidurl-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-18 02:43:07 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
d54432fbea838c2c3976b7d353526d0298d8f36d.

Powered by Google App Engine
This is Rietveld 408576698