Use Document::validBaseElementURL to init preloadscanner

Use Document::validBaseElementURL to init preloadscanner

Before this CL, Document::baseElementURL was used to initialize
PreloadScanner. However, this URL can be !isValid().

This CL introduces Document::validBaseElementURL() which returns
baseElementURL only when its valid, end returns empty URL when its invalid.
This can safely be used to initialize preload scanner.

BUG=623365
Committed: https://crrev.com/51b5da563d004465a203dd40892a13b8543721e1
Cr-Commit-Position: refs/heads/master@{#404595}

[kouhei (in TOK), 2016-07-10 16:18:27]

kouhei@chromium.org changed reviewers:
+ csharrison@chromium.org, haraken@chromium.org, yoav@yoav.ws

[kouhei (in TOK), 2016-07-10 16:18:33]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-10 16:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-10 17:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-10 17:44:07]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-07-10 18:02:11]

Can the layout test be simpler / more reduced? I don't have access to the bug
but I'm curious why the base element has to be document.written.

If possible, it would be nice to ensure all the scanAndPreload code paths are
tested.

[kouhei (in TOK), 2016-07-11 00:04:55]

On 2016/07/10 18:02:11, csharrison wrote:
> Can the layout test be simpler / more reduced? I don't have access to the bug
> but I'm curious why the base element has to be document.written.
> 
> If possible, it would be nice to ensure all the scanAndPreload code paths are
> tested.

The preload suspect element has to be parsed from inlinePreloadScanner

[haraken, 2016-07-11 03:39:11]

LGTM

[kouhei (in TOK), 2016-07-11 03:39:30]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-07-11 03:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 03:43:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 03:45:39]

Description was changed from

==========
Use Document::validBaseElementURL to init preloadscanner

Before this CL, Document::baseElementURL was used to initialize
PreloadScanner. However, this URL can be !isValid().

This CL introduces Document::validBaseElementURL() which returns
baseElementURL only when its valid, end returns empty URL when its invalid.
This can safely be used to initialize preload scanner.

BUG=623365
==========

to

==========
Use Document::validBaseElementURL to init preloadscanner

Before this CL, Document::baseElementURL was used to initialize
PreloadScanner. However, this URL can be !isValid().

This CL introduces Document::validBaseElementURL() which returns
baseElementURL only when its valid, end returns empty URL when its invalid.
This can safely be used to initialize preload scanner.

BUG=623365

Committed: https://crrev.com/51b5da563d004465a203dd40892a13b8543721e1
Cr-Commit-Position: refs/heads/master@{#404595}
==========

[commit-bot: I haz the power, 2016-07-11 03:45:41]

Patchset 1 (id:??) landed as
https://crrev.com/51b5da563d004465a203dd40892a13b8543721e1
Cr-Commit-Position: refs/heads/master@{#404595}

[Yoav Weiss, 2016-07-11 07:40:19]

On 2016/07/11 03:45:41, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/51b5da563d004465a203dd40892a13b8543721e1
> Cr-Commit-Position: refs/heads/master@{#404595}

LGTM