tools/gn/command_refs.cc - Issue 2160383002: Make `gn refs` handle files in data directories properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_refs.cc

Issue 2160383002: Make `gn refs` handle files in data directories properly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn_refs_scripts

Patch Set: use base::StartsWith Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/command_refs.cc

diff --git a/tools/gn/command_refs.cc b/tools/gn/command_refs.cc

index fcd824a6842ea72bef034ec308055d02d8a17664..64969b9e80dcbddfe9fef4e2da7f929fec2bc5cb 100644

--- a/tools/gn/command_refs.cc

+++ b/tools/gn/command_refs.cc

@@ -10,6 +10,7 @@

#include "base/command_line.h"

#include "base/files/file_util.h"

#include "base/strings/string_split.h"

+#include "base/strings/string_util.h"

#include "tools/gn/commands.h"

#include "tools/gn/deps_iterator.h"

#include "tools/gn/filesystem_utils.h"

@@ -143,6 +144,9 @@ bool TargetContainsFile(const Target* target, const SourceFile& file) {

for (const auto& cur_file : target->data()) {

if (cur_file == file.value())

return true;

+ if (cur_file.back() == '/' &&

+ base::StartsWith(file.value(), cur_file, base::CompareCase::SENSITIVE))

+ return true;

}

if (target->action_values().script().value() == file.value())

« no previous file with comments | « no previous file | no next file » | no next file with comments »