Fix file manager labels and aria role.

Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things, tells Blink to  fire an active descendant change event when the aria-activedescendant id changes. This also causes ChromeVox to announce the tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with the HTMLElement via aria-label. Note that a client such as ChromeVox would not have any other way of knowing this label other than a heuristic like reading hte descendants of the tree item. In this case, that won't work because the tree items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items. Previously, we only dealt with entering tree tiems because we only placed range around a tree item via navigation. However, it's possible to focus tree items via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58
Cr-Commit-Position: refs/heads/master@{#411545}

[David Tseng, 2016-07-19 17:28:56]

Description was changed from

==========
Fix file manager labels and aria role.
==========

to

==========
Fix file manager labels and aria role.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 17:34:26]

Description was changed from

==========
Fix file manager labels and aria role.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.



CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 17:34:26]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, michaelpg@chromium.org

[David Tseng, 2016-07-19 17:36:36]

Description was changed from

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.



CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-19 17:37:09]

michaelpg for ui/*
dmazzoni for ChromeVox.

[dmazzoni, 2016-07-19 19:14:59]

lgtm

https://codereview.chromium.org/2160303002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2160303002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:547:
speak: '$name ' +
indentation should match "enter"?

[michaelpg, 2016-07-19 19:20:25]

ui/ lgtm

[David Tseng, 2016-07-19 20:35:17]

https://codereview.chromium.org/2160303002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2160303002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:547:
speak: '$name ' +
On 2016/07/19 19:14:59, dmazzoni wrote:
> indentation should match "enter"?

Done.

[David Tseng, 2016-07-19 20:39:40]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-07-19 20:39:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2160303002/#ps20001
(title: "m")

[commit-bot: I haz the power, 2016-07-19 20:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 20:52:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 20:52:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Tseng, 2016-07-26 17:32:46]

dtseng@chromium.org changed reviewers:
+ yawano@chromium.org

[David Tseng, 2016-07-26 17:32:47]

+ yawano for ui/file_manager/

[David Tseng, 2016-07-26 17:33:57]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 17:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-07-26 22:13:48]

lgtm

lgtm for chromevox

[yawano, 2016-07-27 01:22:08]

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:125:
item.setAttribute('aria-label', label);
Should we use aria-labelledby since the label is visible in the UI? -
https://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby

[David Tseng, 2016-08-08 21:32:02]

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:125:
item.setAttribute('aria-label', label);
On 2016/07/27 01:22:08, yawano wrote:
> Should we use aria-labelledby since the label is visible in the UI? -
> https://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby

I was poking around this file awhile ago before this change and iirc, the issue
was the label nodes need to have a unique id for us to use aria-labelledby --
complicating the change.

I don't think we need it for this case.

[chromium-reviews, 2016-08-08 21:39:45]

I just updated ui/webui/resources/js/cr/ui/tree.js to do something similar.

Does this class possibly inherit from the class I modified?


-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-08-08 22:32:12]

Possibly, but the subclass does it's own thing. I'll take a look.

On Mon, Aug 8, 2016 at 2:39 PM, 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> I just updated ui/webui/resources/js/cr/ui/tree.js to do something
> similar.
>
> Does this class possibly inherit from the class I modified?
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-08-11 00:56:37]

Still need this change. Friendly ping @ywano

[yawano, 2016-08-12 00:46:43]

lgtm. Sorry for this late reply.

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/2160303002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:125:
item.setAttribute('aria-label', label);
On 2016/08/08 21:32:02, David Tseng wrote:
> On 2016/07/27 01:22:08, yawano wrote:
> > Should we use aria-labelledby since the label is visible in the UI? -
> > https://www.w3.org/TR/wai-aria/states_and_properties#aria-labelledby
> 
> I was poking around this file awhile ago before this change and iirc, the
issue
> was the label nodes need to have a unique id for us to use aria-labelledby --
> complicating the change.
> 
> I don't think we need it for this case.

Acknowledged.

[David Tseng, 2016-08-12 02:35:53]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 02:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2016-08-12 02:37:51]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2016-08-12 02:37:52]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-08-12 02:37:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2160303002/#ps40001
(title: "m")

[commit-bot: I haz the power, 2016-08-12 02:38:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 03:43:54]

Description was changed from

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-12 03:43:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 03:46:16]

Description was changed from

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix file manager labels and aria role.

1. Give the "tree" widget an Aria role of "tree". This, among other things,
tells Blink to  fire an active descendant change event when the
aria-activedescendant id changes. This also causes ChromeVox to announce the
tree view as a "tree" rather than a "group"
2. make the DirectoryItem which takes a string label associate that label with
the HTMLElement via aria-label. Note that a client such as ChromeVox would not
have any other way of knowing this label other than a heuristic like reading hte
descendants of the tree item. In this case, that won't work because the tree
items can and do nest other tree items.
3. modify ChromeVox's output rules to add a rule for speaking tree items.
Previously, we only dealt with entering tree tiems because we only placed range
around a tree item via navigation. However, it's possible to focus tree items
via active descendant or explicit page focus, so provide a rule for this case.

BUG=628972

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58
Cr-Commit-Position: refs/heads/master@{#411545}
==========

[commit-bot: I haz the power, 2016-08-12 03:46:17]

Patchset 3 (id:??) landed as
https://crrev.com/ac22ee8c6545be19f2208bdd1f13d6dcfddc1c58
Cr-Commit-Position: refs/heads/master@{#411545}