Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Issue 2160303002: Fix file manager labels and aria role. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: m Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
index cfb4b1e84e91bd435db1a8d12604b13dc4bb6a59..317e9792f231a8a172f92aa5799c7fc804d002e9 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
@@ -28,7 +28,7 @@ DirectoryItemTreeBaseMethods.getItemByEntry = function(entry) {
// The Drive root volume item "Google Drive" and its child "My Drive" have
// the same entry. When we look for a tree item of Drive's root directory,
// "My Drive" should be returned, as we use "Google Drive" for grouping
- // "My Drive", "Shared with me", "Recent", and "Offine".
+ // "My Drive", "Shared with me", "Recent", and "Offline".
// Therefore, we have to skip "Google Drive" here.
if (item instanceof DriveVolumeItem)
return item.getItemByEntry(entry);
@@ -122,6 +122,8 @@ function DirectoryItem(label, tree) {
item.hasChildren = false;
item.label = label;
+ item.setAttribute('aria-label', label);
yawano 2016/07/27 01:22:08 Should we use aria-labelledby since the label is v
David Tseng 2016/08/08 21:32:02 I was poking around this file awhile ago before th
yawano 2016/08/12 00:46:43 Acknowledged.
+
return item;
}
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | ui/webui/resources/js/cr/ui/tree.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698