Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2160133002: Revert of Support for retreiving the monitor color space on X11. (Closed)

Created:
4 years, 5 months ago by hubbe
Modified:
4 years, 5 months ago
Reviewers:
ccameron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support for retreiving the monitor color space on X11. (patchset #2 id:20001 of https://codereview.chromium.org/2115103002/ ) Reason for revert: Temporary revert as it breaks layout tests for many people. Original issue's description: > Support for retreiving the monitor color space on X11. > > BUG=622133 > > Committed: https://crrev.com/b0df9e3fcbca19d2a625fa274172bd3be4116261 > Cr-Commit-Position: refs/heads/master@{#403958} TBR=ccameron@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622133 Committed: https://crrev.com/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6 Cr-Commit-Position: refs/heads/master@{#406181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -47 lines) Patch
M ui/gfx/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M ui/gfx/color_space.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/color_space_x11.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
hubbe
Created Revert of Support for retreiving the monitor color space on X11.
4 years, 5 months ago (2016-07-18 23:30:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160133002/1
4 years, 5 months ago (2016-07-18 23:33:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 02:00:13 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 02:00:15 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 02:03:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e94e1ca3c70ac232c26b77b6a8cc17ba54307b6
Cr-Commit-Position: refs/heads/master@{#406181}

Powered by Google App Engine
This is Rietveld 408576698