Clean up repack.py and repack_locale.py usage.

Clean up repack.py and repack_locale.py usage.

- Creates repack_pack.gypi action
- Updates all the call-sites of repack.py
- Removes chrome_repack_pseudo_locales.gypi to instead use
  chrome_repack_locales.gypi
- Remove unused repack_locales_cmd list

BUG=338759
R=tfarina@chromium.org, thakis@chromium.org
TBR=asargent@chromium.org, benm@chromium.org, blundell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260279

[aurimas (slooooooooow), 2014-03-28 01:54:50]

Hey Nico,

Please take a look at this change.

Thanks!
Aurimas

[tfarina, 2014-03-28 02:24:06]

I reviewed only ui_resources.gyp. lgtm

https://chromiumcodereview.appspot.com/216013003/diff/1/ui/resources/ui_resou...
File ui/resources/ui_resources.gyp (right):

https://chromiumcodereview.appspot.com/216013003/diff/1/ui/resources/ui_resou...
ui/resources/ui_resources.gyp:59: 'includes': [ '../../build/repack_action.gypi'
],
cool! thanks!

[Nico, 2014-03-28 03:08:24]

neato, lgtm

https://chromiumcodereview.appspot.com/216013003/diff/1/build/repack_action.gypi
File build/repack_action.gypi (right):

https://chromiumcodereview.appspot.com/216013003/diff/1/build/repack_action.g...
build/repack_action.gypi:9: #   pak_output: string: the output pak file path.
I suppose alternatively clients could set 'outputs' directly and this could use
<(_outputs) instead of <(pak_output). Not sure which way is better; probably
doesn't matter much.

[aurimas (slooooooooow), 2014-03-28 04:44:39]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-03-28 04:46:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/216013003/1

[commit-bot: I haz the power, 2014-03-28 08:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 08:30:15]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[aurimas (slooooooooow), 2014-03-28 14:46:32]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-03-28 14:48:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/216013003/1

[aurimas (slooooooooow), 2014-03-28 21:11:24]

Committed patchset #1 manually as r260279 (presubmit successful).

[blundell, 2014-03-31 13:47:42]

//components LGTM

[tfarina, 2014-04-02 19:11:37]

https://codereview.chromium.org/216013003/diff/1/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/216013003/diff/1/content/content_shell.gypi#n...
content/content_shell.gypi:500: 'pak_output':
'<(PRODUCT_DIR)/content_shell.pak',
this isn't inside 'variables', does that make any difference? I notice that
pak_inputs is, but pak_output isn't. hence it might not being generating a
pak_output variable.

[blundell, 2014-04-03 08:43:43]

https://codereview.chromium.org/216013003/diff/1/content/content_shell.gypi
File content/content_shell.gypi (right):

https://codereview.chromium.org/216013003/diff/1/content/content_shell.gypi#n...
content/content_shell.gypi:500: 'pak_output':
'<(PRODUCT_DIR)/content_shell.pak',
The conditions block is actually within a 'variables' dictionary -- in fact, the
inner 'variables' dictionary at 495 is probably unnecessary.

On 2014/04/02 19:11:38, tfarina wrote:
> this isn't inside 'variables', does that make any difference? I notice that
> pak_inputs is, but pak_output isn't. hence it might not being generating a
> pak_output variable.