Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: apps/apps.gypi

Issue 216013003: Clean up repack.py and repack_locale.py usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/android_webview.gyp ('k') | build/repack_action.gypi » ('j') | build/repack_action.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: apps/apps.gypi
diff --git a/apps/apps.gypi b/apps/apps.gypi
index bead5d86d7c3c5776b05637a6f37bdd033471fb0..9a295bffbd5dafa74f2faa56acc97fdcafe3311c 100644
--- a/apps/apps.gypi
+++ b/apps/apps.gypi
@@ -117,9 +117,6 @@
'../ui/base/strings/ui_strings.gyp:ui_strings',
'../ui/resources/ui_resources.gyp:ui_resources',
],
- 'variables': {
- 'repack_path': '<(DEPTH)/tools/grit/grit/format/repack.py',
- },
'actions': [
{
'action_name': 'repack_app_shell_pack',
@@ -139,16 +136,9 @@
'<(SHARED_INTERMEDIATE_DIR)/ui/ui_strings/ui_strings_en-US.pak',
'<(SHARED_INTERMEDIATE_DIR)/webkit/devtools_resources.pak',
],
+ 'pak_output': '<(PRODUCT_DIR)/app_shell.pak',
},
- 'inputs': [
- '<(repack_path)',
- '<@(pak_inputs)',
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/app_shell.pak',
- ],
- 'action': ['python', '<(repack_path)', '<@(_outputs)',
- '<@(pak_inputs)'],
+ 'includes': [ '../build/repack_action.gypi' ],
},
],
},
« no previous file with comments | « android_webview/android_webview.gyp ('k') | build/repack_action.gypi » ('j') | build/repack_action.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698