Chromium Code Reviews Chromium Code Reviews
Issue 2160003002:
Add UMA to record why chrome shows generic warning (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index e90336494d96df158b3cc62e6eb612df59bc7b23..646127c8b731f400a7236c2506460a20fc0fc51c 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -10602,6 +10602,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="Download.DangerousFile.Reason" enum="DangerousFile.Reason"> |
| + <owner>jialiul@chromium.org</owner> |
| + <owner>nparker@chromium.org</owner> |
| + <summary> |
| + Indicates why a download is mared as DANGEROUS_FILE. Grouped by reason, such |
|
Nathan Parker
2016/07/18 21:21:38
s/mared/marked
Can you add a comment about how th
Jialiu Lin
2016/07/18 21:45:18
Done
|
| + as Safe Browsing (SB) service is not available, and SB returns UNKOWN or |
| + SAFE verdict. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Download.DangerousFile.UserDiscard" |
| enum="DownloadItem.DangerousFileType"> |
| <owner>asanka@chromium.org</owner> |
| @@ -70410,6 +70420,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="2" label="Clock Changed"/> |
| </enum> |
| +<enum name="DangerousFile.Reason" type="int"> |
| + <int value="0" label="Safe Browsing is not available"/> |
| + <int value="1" label="Safe Browsing returns UNKOWN"/> |
| + <int value="2" label="Safe Browsing returns SAFE"/> |
| +</enum> |
| + |
| <enum name="DarkResumeScanRetryResult" type="int"> |
| <int value="0" label="Not Connected"/> |
| <int value="1" label="Connected"/> |
