Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 215993002: Clean up callback interface code and template (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Clean up callback interface code and template The callback interface code was the first code and template we wrote. Since then we've improved style and template usage; this simplifies the code and brings it up-to-date. TBR=haraken BUG=345503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M Source/bindings/scripts/v8_callback_interface.py View 3 chunks +16 lines, -26 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Quick clean-up.
6 years, 9 months ago (2014-03-28 01:27:07 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-28 01:27:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/215993002/1
6 years, 9 months ago (2014-03-28 01:27:16 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-28 01:29:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:53:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-28 01:53:32 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-28 02:29:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/215993002/1
6 years, 9 months ago (2014-03-28 02:30:23 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 02:52:36 UTC) #9
Message was sent while issue was closed.
Change committed as 170254

Powered by Google App Engine
This is Rietveld 408576698