Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: Source/bindings/templates/callback_interface.cpp

Issue 215993002: Clean up callback interface code and template (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_callback_interface.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/callback_interface.cpp
diff --git a/Source/bindings/templates/callback_interface.cpp b/Source/bindings/templates/callback_interface.cpp
index dbdf66cca61f8dacd05fdb8d20395aef852b4b0a..5199616ddb77498db33ffb0182062adda40c3a7c 100644
--- a/Source/bindings/templates/callback_interface.cpp
+++ b/Source/bindings/templates/callback_interface.cpp
@@ -51,15 +51,15 @@ namespace WebCore {
ASSERT(thisHandle->IsObject());
{% endif %}
{% for argument in method.arguments %}
- {{argument.cpp_to_v8_conversion | indent}}
- if ({{argument.name}}Handle.IsEmpty()) {
+ v8::Handle<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};
+ if ({{argument.handle}}.IsEmpty()) {
if (!isScriptControllerTerminating())
CRASH();
{{return_default}};
}
{% endfor %}
{% if method.arguments %}
- v8::Handle<v8::Value> argv[] = { {{method.handles | join(', ')}} };
+ v8::Handle<v8::Value> argv[] = { {{method.arguments | join(', ', attribute='handle')}} };
{% else %}
v8::Handle<v8::Value> *argv = 0;
{% endif %}
« no previous file with comments | « Source/bindings/scripts/v8_callback_interface.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698