Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2159923002: [TTS] Handle showing of a Context Menu more gracefully. (Closed)

Created:
4 years, 5 months ago by amineer
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[TTS] Handle showing of a Context Menu more gracefully. When the TTS UX is showing and the user activates a context menu, the selection controller gets an event sequence that's confusing, causing a tap-selection to show the selection handles. This change hides the Contextual Search UX, and adds a state where the selection controller knows to ignore the next event that would show the selection handles, when a context menu has just been shown. This change cleans up a sequence implicated in a crash, so that won't be reproducible through triggering the Context Menu anymore. (Issue 562353) BUG=628436, 562353 Review-Url: https://codereview.chromium.org/2150213002 Cr-Commit-Position: refs/heads/master@{#405901} (cherry picked from commit b09e3678e18b7d6447e1c758263d290b20b18a7f) Committed: https://chromium.googlesource.com/chromium/src/+/fc73bd54293f704974c46c7c5043d50b98315eee

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
amineer
4 years, 5 months ago (2016-07-18 18:34:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc73bd54293f704974c46c7c5043d50b98315eee.

Powered by Google App Engine
This is Rietveld 408576698