[TTS] Handle showing of a Context Menu more gracefully.

[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436, 562353
Committed: https://crrev.com/b09e3678e18b7d6447e1c758263d290b20b18a7f
Cr-Commit-Position: refs/heads/master@{#405901}

[Donn Denman, 2016-07-15 16:34:51]

Description was changed from

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets and event sequence that's confusing.
This change adds a state where the selection controller knows to
ignore these events when a context menu has just been shown.

BUG=628436
==========

to

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets and event sequence that's confusing.
This change adds a state where the selection controller knows to
ignore these events when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

[Donn Denman, 2016-07-15 16:35:34]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2016-07-15 16:35:35]

Theresa, PTAL.  Thanks!

[Donn Denman, 2016-07-15 21:50:20]

Description was changed from

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets and event sequence that's confusing.
This change adds a state where the selection controller knows to
ignore these events when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

to

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

[Donn Denman, 2016-07-15 21:50:49]

On 2016/07/15 16:35:35, Donn Denman wrote:
> Theresa, PTAL.  Thanks!

Theresa, updated to address your f2f comments.  PTAL.  Thanks!

[Theresa, 2016-07-15 22:25:42]

lgtm

[Donn Denman, 2016-07-15 22:27:23]

The CQ bit was checked by donnd@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 23:42:26]

Description was changed from

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

to

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

[commit-bot: I haz the power, 2016-07-15 23:42:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-15 23:42:36]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 23:44:28]

Description was changed from

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353
==========

to

==========
[TTS] Handle showing of a Context Menu more gracefully.

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353

Committed: https://crrev.com/b09e3678e18b7d6447e1c758263d290b20b18a7f
Cr-Commit-Position: refs/heads/master@{#405901}
==========

[commit-bot: I haz the power, 2016-07-15 23:44:29]

Patchset 4 (id:??) landed as
https://crrev.com/b09e3678e18b7d6447e1c758263d290b20b18a7f
Cr-Commit-Position: refs/heads/master@{#405901}