|
|
Created:
4 years, 5 months ago by petrcermak Modified:
4 years, 5 months ago Reviewers:
nednguyen CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[system-health] Run all SH stories in memory benchmarks
This patch modifies SH memory benchmarks (system_health.memory_desktop
and system_health.memory_mobile) to run all SH stories:
- load:* (already running)
- browse:* (NEW)
As a result, all SH stories will also run in the SH smoke test on the
Chromium CQ
(benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*).
*** NOTE TO SHERIFF ***
This patch is very likely to cause failures in the System Health
benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact
me before reverting.
BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/77952f99e4ae203b6b57005ce9e3476895426b96
Cr-Commit-Position: refs/heads/master@{#406309}
Patch Set 1 #Patch Set 2 : Disable several stories in desktop SH smoke tests #Patch Set 3 : Disable several stories in mobile SH smoke tests #Patch Set 4 : Disable the correct stories on mobile #
Messages
Total messages: 43 (22 generated)
Description was changed from ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). BUG=589726 ========== to ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
petrcermak@chromium.org changed reviewers: + nednguyen@google.com
PTAL. Thanks, Petr
The CQ bit was checked by nednguyen@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2159733002/#ps20001 (title: "Disable several stories in desktop SH smoke tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/18 14:56:53, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Do you see similar stack trace to crbug.com/624474?
On 2016/07/18 14:59:11, nednguyen wrote: > On 2016/07/18 14:56:53, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > Do you see similar stack trace to crbug.com/624474? Looks like we are also blowing up the budget of 960s on linux_android_rel_ng: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi... :-(
On 2016/07/18 15:04:05, nednguyen wrote: > On 2016/07/18 14:59:11, nednguyen wrote: > > On 2016/07/18 14:56:53, commit-bot: I haz the power wrote: > > > CQ is trying da patch. Follow status at > > > > > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... > > > > Do you see similar stack trace to crbug.com/624474? > > Looks like we are also blowing up the budget of 960s on linux_android_rel_ng: > https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi... > > :-( Are you talking about the Android bot? I think that the failure is due to OOM. I didn't disable the failing stories yet because I want to figure out if the failures are deterministic or flakes.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2159733002/#ps40001 (title: "Disable several stories in mobile SH smoke tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2159733002/#ps60001 (title: "Disable the correct stories on mobile")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
Description was changed from ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
On 2016/07/19 17:10:56, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...) I removed master.tryserver.chromium.perf:android_s5_perf_cq to land this. If it's failing on bot, we can disable failing story in subsequent CL.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/77952f99e4ae203b6b57005ce9e3476895426b96 Cr-Commit-Position: refs/heads/master@{#406309} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/77952f99e4ae203b6b57005ce9e3476895426b96 Cr-Commit-Position: refs/heads/master@{#406309} |