Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2159733002: [system-health] Run all SH stories in memory benchmarks (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system-health] Run all SH stories in memory benchmarks This patch modifies SH memory benchmarks (system_health.memory_desktop and system_health.memory_mobile) to run all SH stories: - load:* (already running) - browse:* (NEW) As a result, all SH stories will also run in the SH smoke test on the Chromium CQ (benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*). *** NOTE TO SHERIFF *** This patch is very likely to cause failures in the System Health benchmarks (perf waterfall) and smoke tests (regular CQ). Please contact me before reverting. BUG=589726 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/77952f99e4ae203b6b57005ce9e3476895426b96 Cr-Commit-Position: refs/heads/master@{#406309}

Patch Set 1 #

Patch Set 2 : Disable several stories in desktop SH smoke tests #

Patch Set 3 : Disable several stories in mobile SH smoke tests #

Patch Set 4 : Disable the correct stories on mobile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tools/perf/benchmarks/system_health.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/system_health_smoke_test.py View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 43 (22 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 5 months ago (2016-07-18 13:39:15 UTC) #4
nednguyen
lgtm
4 years, 5 months ago (2016-07-18 13:43:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/1
4 years, 5 months ago (2016-07-18 13:44:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105490) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-18 14:19:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/20001
4 years, 5 months ago (2016-07-18 14:56:53 UTC) #12
nednguyen
On 2016/07/18 14:56:53, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-18 14:59:11 UTC) #13
nednguyen
On 2016/07/18 14:59:11, nednguyen wrote: > On 2016/07/18 14:56:53, commit-bot: I haz the power wrote: ...
4 years, 5 months ago (2016-07-18 15:04:05 UTC) #14
petrcermak
On 2016/07/18 15:04:05, nednguyen wrote: > On 2016/07/18 14:59:11, nednguyen wrote: > > On 2016/07/18 ...
4 years, 5 months ago (2016-07-18 15:07:42 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/246495)
4 years, 5 months ago (2016-07-18 15:54:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/20001
4 years, 5 months ago (2016-07-18 15:55:56 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105557)
4 years, 5 months ago (2016-07-18 16:50:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/40001
4 years, 5 months ago (2016-07-18 17:17:10 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105691)
4 years, 5 months ago (2016-07-18 19:01:20 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/60001
4 years, 5 months ago (2016-07-19 11:54:49 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/393)
4 years, 5 months ago (2016-07-19 17:10:56 UTC) #31
nednguyen
On 2016/07/19 17:10:56, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 5 months ago (2016-07-19 17:15:30 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/60001
4 years, 5 months ago (2016-07-19 17:16:08 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159733002/60001
4 years, 5 months ago (2016-07-19 17:26:06 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-19 18:00:22 UTC) #40
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 18:00:36 UTC) #41
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:03:22 UTC) #43
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/77952f99e4ae203b6b57005ce9e3476895426b96
Cr-Commit-Position: refs/heads/master@{#406309}

Powered by Google App Engine
This is Rietveld 408576698