Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2159733002: [system-health] Run all SH stories in memory benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable the correct stories on mobile Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 16 matching lines...) Expand all
27 sh_benchmark_classes = discover.DiscoverClassesInModule( 27 sh_benchmark_classes = discover.DiscoverClassesInModule(
28 system_health, perf_benchmark.PerfBenchmark, 28 system_health, perf_benchmark.PerfBenchmark,
29 index_by_class_name=True).values() 29 index_by_class_name=True).values()
30 return list(b for b in sh_benchmark_classes if 30 return list(b for b in sh_benchmark_classes if
31 b.Name().startswith('system_health.memory')) 31 b.Name().startswith('system_health.memory'))
32 32
33 33
34 _DISABLED_TESTS = frozenset({ 34 _DISABLED_TESTS = frozenset({
35 # crbug.com/624474 35 # crbug.com/624474
36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long 36 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long
37 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long
38 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:nytimes', # pylint: disable=line-too-long
39 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:reddit', # pylint: disable=line-too-long
40 # crbug.com/622409
41 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:news:cnn', # pylint: disable=line-too-long
42 # crbug.com/629123
43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:hackernews', # pylint: disable=line-too-long
44 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.browse:news:nytimes', # pylint: disable=line-too-long
37 }) 45 })
38 46
39 47
40 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 48 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
41 49
42 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 50 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
43 # 51 #
44 # This smoke test dynamically tests all system health user stories. So 52 # This smoke test dynamically tests all system health user stories. So
45 # disabling it for one failing or flaky benchmark would disable a much 53 # disabling it for one failing or flaky benchmark would disable a much
46 # wider swath of coverage than is usally intended. Instead, if a test is 54 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 # parsed during test time which happens after load_tests are called. 128 # parsed during test time which happens after load_tests are called.
121 # Since none of our system health benchmarks creates stories based on 129 # Since none of our system health benchmarks creates stories based on
122 # command line options, it should be ok to pass options=None to 130 # command line options, it should be ok to pass options=None to
123 # CreateStorySet. 131 # CreateStorySet.
124 for story_to_smoke_test in ( 132 for story_to_smoke_test in (
125 benchmark_class().CreateStorySet(options=None).stories): 133 benchmark_class().CreateStorySet(options=None).stories):
126 suite.addTest( 134 suite.addTest(
127 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 135 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
128 136
129 return suite 137 return suite
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/system_health.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698